linux-kernel - Re: [PATCH 1/1] selinux: add the processing of the failure of avc_add_xperms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7063e0206fb6100d94114db6f8a0c538@paul-moore.com>
Date: Wed, 07 Aug 2024 15:14:35 -0400
From: Paul Moore <paul@...l-moore.com>
To: thunder.leizhen@...weicloud.com, Stephen Smalley <stephen.smalley.work@...il.com>, Ondrej Mosnacek <omosnace@...hat.com>, selinux@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Zhen Lei <thunder.leizhen@...wei.com>, Nick Kralevich <nnk@...gle.com>, Jeff Vander Stoep <jeffv@...gle.com>
Subject: Re: [PATCH 1/1] selinux: add the processing of the failure of  avc_add_xperms_decision()

On Aug  7, 2024 thunder.leizhen@...weicloud.com wrote:
> 
> When avc_add_xperms_decision() fails, the information recorded by the new
> avc node is incomplete. In this case, the new avc node should be released
> instead of replacing the old avc node.
> 
> Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
> Suggested-by: Stephen Smalley <stephen.smalley.work@...il.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> Acked-by: Stephen Smalley <stephen.smalley.work@...il.com>
> ---
>  security/selinux/avc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Thanks, this looks good to me.  I'm going to merge this into
selinux/stable-6.11 with the idea of sending it, and your other
patch, up to Linus tomorrow, or potentially next week.

Thanks for your help!

--
paul-moore.com