linux-kernel - Re: [PATCH v2] hwmon: Add thermal sensor driver for Surface Aggregator Module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d11350f-71b0-44fc-8631-01e1740581d6@gmail.com>
Date: Wed, 7 Aug 2024 21:25:16 +0200
From: Maximilian Luz <luzmaximilian@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Jean Delvare <jdelvare@...e.com>, Hans de Goede <hdegoede@...hat.com>,
 Ivor Wanders <ivor@...nders.net>, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: Add thermal sensor driver for Surface
 Aggregator Module

On 8/7/24 2:32 AM, Guenter Roeck wrote:
> On 8/4/24 16:08, Maximilian Luz wrote:

[...]

>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>> index b60fe2e58ad6..70c6385f0ed6 100644
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -2080,6 +2080,16 @@ config SENSORS_SURFACE_FAN
>>         Select M or Y here, if you want to be able to read the fan's speed.
>> +config SENSORS_SURFACE_TEMP
>> +    tristate "Microsoft Surface Thermal Sensor Driver"
>> +    depends on SURFACE_AGGREGATOR
> 
> As the kernel test robot points out, this dependency is wrong.
> __ssam_device_driver_register() is only available
> if SURFACE_AGGREGATOR_BUS is enabled.

Right, I should have spotted this before submission, sorry. This should
be

   depends on SURFACE_AGGREGATOR
   depends on SURFACE_AGGREGATOR_BUS

I'll fix that for v3 and likely re-spin this weekend. Anything else I
should address for that?

Regards,
Max