linux-kernel - Re: [PATCH] Documentation: dm-crypt.rst warning + error fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zfpoqg9n.fsf@trenco.lwn.net>
Date: Wed, 07 Aug 2024 13:33:56 -0600
From: Jonathan Corbet <corbet@....net>
To: Daniel Yang <danielyangkang@...il.com>, skhan@...uxfoundation.org
Cc: danielyangkang@...il.com, Alasdair Kergon <agk@...hat.com>, Mike Snitzer
 <snitzer@...nel.org>, Mikulas Patocka <mpatocka@...hat.com>,
 dm-devel@...ts.linux.dev, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: dm-crypt.rst warning + error fix

Daniel Yang <danielyangkang@...il.com> writes:

> Signed-off-by: Daniel Yang <danielyangkang@...il.com>
> ---
>  .../admin-guide/device-mapper/dm-crypt.rst        | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/admin-guide/device-mapper/dm-crypt.rst b/Documentation/admin-guide/device-mapper/dm-crypt.rst
> index e625830d335..552c9155165 100644
> --- a/Documentation/admin-guide/device-mapper/dm-crypt.rst
> +++ b/Documentation/admin-guide/device-mapper/dm-crypt.rst
> @@ -162,13 +162,14 @@ iv_large_sectors
>  
>  
>  Module parameters::
> -max_read_size
> -max_write_size
> -   Maximum size of read or write requests. When a request larger than this size
> -   is received, dm-crypt will split the request. The splitting improves
> -   concurrency (the split requests could be encrypted in parallel by multiple
> -   cores), but it also causes overhead. The user should tune these parameters to
> -   fit the actual workload.
> +
> +   max_read_size
> +   max_write_size
> +      Maximum size of read or write requests. When a request larger than this size
> +      is received, dm-crypt will split the request. The splitting improves
> +      concurrency (the split requests could be encrypted in parallel by multiple
> +      cores), but it also causes overhead. The user should tune these parameters to
> +      fit the actual workload.

Thanks for the patch.  It would have been better to include a proper
changelog, even for a simple change like this.  Unfortunately, I got
another fix for this error a few days ago, and have applied that.

jon