[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <A17155F6-1B57-4B25-BAB5-C03A59BBB8E3@fb.com>
Date: Wed, 7 Aug 2024 20:40:33 +0000
From: Song Liu <songliubraving@...a.com>
To: Steven Rostedt <rostedt@...dmis.org>
CC: Song Liu <songliubraving@...a.com>,
Masami Hiramatsu
<mhiramat@...nel.org>, Song Liu <song@...nel.org>,
"live-patching@...r.kernel.org" <live-patching@...r.kernel.org>,
LKML
<linux-kernel@...r.kernel.org>,
"linux-trace-kernel@...r.kernel.org"
<linux-trace-kernel@...r.kernel.org>,
Josh Poimboeuf <jpoimboe@...nel.org>, Jiri Kosina <jikos@...nel.org>,
Miroslav Benes <mbenes@...e.cz>, Petr Mladek
<pmladek@...e.com>,
Joe Lawrence <joe.lawrence@...hat.com>,
Nathan Chancellor
<nathan@...nel.org>,
"morbo@...gle.com" <morbo@...gle.com>,
Justin Stitt
<justinstitt@...gle.com>,
Luis Chamberlain <mcgrof@...nel.org>,
Leizhen
<thunder.leizhen@...wei.com>,
"kees@...nel.org" <kees@...nel.org>,
Kernel
Team <kernel-team@...a.com>,
Matthew Maurer <mmaurer@...gle.com>,
Sami
Tolvanen <samitolvanen@...gle.com>
Subject: Re: [PATCH v2 3/3] tracing/kprobes: Use APIs that matches symbols
without .XXX suffix
> On Aug 7, 2024, at 1:08 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
>
> On Wed, 7 Aug 2024 19:41:11 +0000
> Song Liu <songliubraving@...a.com> wrote:
>
>
>> It appears there are multiple APIs that may need change. For example, on gcc
>> built kernel, /sys/kernel/tracing/available_filter_functions does not show
>> the suffix:
>>
>> [root@(none)]# grep cmos_irq_enable /proc/kallsyms
>> ffffffff81db5470 t __pfx_cmos_irq_enable.constprop.0
>> ffffffff81db5480 t cmos_irq_enable.constprop.0
>> ffffffff822dec6e t cmos_irq_enable.constprop.0.cold
>>
>> [root@(none)]# grep cmos_irq_enable /sys/kernel/tracing/available_filter_functions
>> cmos_irq_enable
>
> Strange, I don't see that:
>
> ~# grep cmos_irq_enable /proc/kallsyms
> ffffffff8f4b2500 t __pfx_cmos_irq_enable.constprop.0
> ffffffff8f4b2510 t cmos_irq_enable.constprop.0
>
> ~# grep cmos_irq_enable /sys/kernel/tracing/available_filter_functions
> cmos_irq_enable.constprop.0
Ah, this is caused by my change. Let me fix that in the next version.
Thanks,
Song
Powered by blists - more mailing lists