linux-kernel - Re: [PATCH] clk: renesas: fix r9a09g057_cpg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0c8bb91f1645d1769e4cd2945bf36f8.sboyd@kernel.org>
Date: Wed, 07 Aug 2024 13:52:22 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cc: Arnd Bergmann <arnd@...db.de>, Michael Turquette <mturquette@...libre.com>, linux-renesas-soc@...r.kernel.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: renesas: fix r9a09g057_cpg_info link error

Quoting Arnd Bergmann (2024-08-07 00:56:58)
> From: Arnd Bergmann <arnd@...db.de>
> 
> The rzv2g-cpg.c driver unconditionally links into the r9a09g057
> one, but that may be disabled:
> 
> aarch64-linux-ld: drivers/clk/renesas/rzv2h-cpg.o:(.rodata+0x440): undefined reference to `r9a09g057_cpg_info'
> 
> Use the same approach here as with the rzg2l variant, using an #ifdef
> around tha data.
> 
> I think both drivers would be better off doing the abstraction the other
> way round, with the platform_driver structure defined in the most specific
> file and the common bits as a library that exports common functions.
> Changing it that way would require a larger rework of course.
> 
> Fixes: 42b54d52ecb7 ("clk: renesas: Add RZ/V2H(P) CPG driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

This is https://lore.kernel.org/r/20240805095842.277792-1-prabhakar.mahadev-lad.rj@bp.renesas.com