linux-kernel - Re: [PATCH] exec: drop a racy path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408071404.4A44CFFF@keescook>
Date: Wed, 7 Aug 2024 14:06:12 -0700
From: Kees Cook <kees@...nel.org>
To: Christian Brauner <brauner@...nel.org>
Cc: Mateusz Guzik <mjguzik@...il.com>, viro@...iv.linux.org.uk,
	jack@...e.cz, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, josef@...icpanda.com,
	wojciech.gladysz@...ogain.com, ebiederm@...ssion.com,
	linux-mm@...ck.org
Subject: Re: [PATCH] exec: drop a racy path_noexec check

On Tue, Aug 06, 2024 at 09:06:17AM +0200, Christian Brauner wrote:
> On Mon, 05 Aug 2024 15:17:21 +0200, Mateusz Guzik wrote:
> > Both i_mode and noexec checks wrapped in WARN_ON stem from an artifact
> > of the previous implementation. They used to legitimately check for the
> > condition, but that got moved up in two commits:
> > 633fb6ac3980 ("exec: move S_ISREG() check earlier")
> > 0fd338b2d2cd ("exec: move path_noexec() check earlier")
> > 
> > Instead of being removed said checks are WARN_ON'ed instead, which
> > has some debug value
> > 
> > [...]
> 
> Applied to the vfs.misc branch of the vfs/vfs.git tree.

NAK, please drop this patch. I want to keep the "redundant"
path_noexec(), since it still provides meaningful signal. We can remove
it from the WARN_ON_ONCE(), but I don't want to drop it.

-- 
Kees Cook