linux-kernel - Re: [PATCH v10 38/40] kselftest/arm64: Add a GCS stress test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877ccsdkjp.fsf@linaro.org>
Date: Wed, 07 Aug 2024 19:39:54 -0300
From: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
To: Mark Brown <broonie@...nel.org>
Cc: Catalin Marinas <catalin.marinas@....com>,  Will Deacon
 <will@...nel.org>,  Jonathan Corbet <corbet@....net>,  Andrew Morton
 <akpm@...ux-foundation.org>,  Marc Zyngier <maz@...nel.org>,  Oliver Upton
 <oliver.upton@...ux.dev>,  James Morse <james.morse@....com>,  Suzuki K
 Poulose <suzuki.poulose@....com>,  Arnd Bergmann <arnd@...db.de>,  Oleg
 Nesterov <oleg@...hat.com>,  Eric Biederman <ebiederm@...ssion.com>,
  Shuah Khan <shuah@...nel.org>,  "Rick P. Edgecombe"
 <rick.p.edgecombe@...el.com>,  Deepak Gupta <debug@...osinc.com>,  Ard
 Biesheuvel <ardb@...nel.org>,  Szabolcs Nagy <Szabolcs.Nagy@....com>,
  Kees Cook <kees@...nel.org>,  "H.J. Lu" <hjl.tools@...il.com>,  Paul
 Walmsley <paul.walmsley@...ive.com>,  Palmer Dabbelt <palmer@...belt.com>,
  Albert Ou <aou@...s.berkeley.edu>,  Florian Weimer <fweimer@...hat.com>,
  Christian Brauner <brauner@...nel.org>,  Ross Burton
 <ross.burton@....com>,  linux-arm-kernel@...ts.infradead.org,
  linux-doc@...r.kernel.org,  kvmarm@...ts.linux.dev,
  linux-fsdevel@...r.kernel.org,  linux-arch@...r.kernel.org,
  linux-mm@...ck.org,  linux-kselftest@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v10 38/40] kselftest/arm64: Add a GCS stress test

Mark Brown <broonie@...nel.org> writes:

> Add a stress test which runs one more process than we have CPUs spinning
> through a very recursive function with frequent syscalls immediately prior
> to return and signals being injected every 100ms. The goal is to flag up
> any scheduling related issues, for example failure to ensure that barriers
> are inserted when moving a GCS using task to another CPU. The test runs for
> a configurable amount of time, defaulting to 10 seconds.
>
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  tools/testing/selftests/arm64/gcs/.gitignore       |   2 +
>  tools/testing/selftests/arm64/gcs/Makefile         |   6 +-
>  tools/testing/selftests/arm64/gcs/asm-offsets.h    |   0
>  .../selftests/arm64/gcs/gcs-stress-thread.S        | 311 ++++++++++++
>  tools/testing/selftests/arm64/gcs/gcs-stress.c     | 530 +++++++++++++++++++++
>  5 files changed, 848 insertions(+), 1 deletion(-)

Unfortunately, gcs-stress still fails on my FVP setup. I tested on an
arm64 defconfig with and without THP enabled with, the same results:

$ sudo ./run_kselftest.sh -t arm64:gcs-stress -o 600
TAP version 13
1..1
# overriding timeout to 600
# selftests: arm64: gcs-stress
# TAP version 13
# 1..9
# # 8 CPUs, 9 GCS threads
# # Will run for 10s
# # Started Thread-4870
# # Started Thread-4871
# # Started Thread-4872
# # Started Thread-4873
# # Started Thread-4874
# # Started Thread-4875
# # Started Thread-4876
# # Started Thread-4877
# # Started Thread-4878
# # Waiting for 9 children
# # Waiting for 9 children
# # Thread-4870: Failed to enable GCS
# # Thread-4871: Failed to enable GCS
# # Thread-4872: Failed to enable GCS
# # Thread-4873: Failed to enable GCS
# # Thread-4876: Failed to enable GCS
# # Thread-4875: Failed to enable GCS
# # Thread-4874: Failed to enable GCS
# # Thread-4878: Failed to enable GCS
# # Thread-4877: Failed to enable GCS
# # Sending signals, timeout remaining: 10000ms
# # Sending signals, timeout remaining: 9900ms
# # Sending signals, timeout remaining: 9800ms
       ⋮
# # Sending signals, timeout remaining: 300ms
# # Sending signals, timeout remaining: 200ms
# # Sending signals, timeout remaining: 100ms
# # Finishing up...
# # Thread-4870 exited with error code 255
# not ok 1 Thread-4870
# # Thread-4871 exited with error code 255
# not ok 2 Thread-4871
# # Thread-4872 exited with error code 255
# not ok 3 Thread-4872
# # Thread-4873 exited with error code 255
# not ok 4 Thread-4873
# # Thread-4874 exited with error code 255
# not ok 5 Thread-4874
# # Thread-4875 exited with error code 255
# not ok 6 Thread-4875
# # Thread-4876 exited with error code 255
# not ok 7 Thread-4876
# # Thread-4877 exited with error code 255
# not ok 8 Thread-4877
# # Thread-4878 exited with error code 255
# not ok 9 Thread-4878
# # Totals: pass:0 fail:9 xfail:0 xpass:0 skip:0 error:0
ok 1 selftests: arm64: gcs-stress
bauermann@...v94:/var/tmp/selftests-arm64-gcs-v10$ echo $?
0

-- 
Thiago