linux-kernel - Re: [PATCH v3 1/5] arm64: dts: ti: k3-j721s2*: Add bootph-* properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807052628.jclbmw4zs72jm6km@uda0497581>
Date: Wed, 7 Aug 2024 10:56:28 +0530
From: Manorit Chawdhry <m-chawdhry@...com>
To: Nishanth Menon <nm@...com>
CC: Andrew Davis <afd@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Tero
 Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Neha Malcom Francis <n-francis@...com>,
        Aniket Limaye <a-limaye@...com>, Udit Kumar <u-kumar1@...com>,
        Beleswar Padhi
	<b-padhi@...com>,
        Siddharth Vadapalli <s-vadapalli@...com>
Subject: Re: [PATCH v3 1/5] arm64: dts: ti: k3-j721s2*: Add bootph-*
 properties

Hi Nishanth,

On 10:07-20240806, Nishanth Menon wrote:
> On 09:43-20240806, Andrew Davis wrote:
> > On 7/30/24 4:53 AM, Manorit Chawdhry wrote:
> > > Adds bootph-* properties to the leaf nodes to enable U-boot to
> > > utilise them.
> > 
> > U-Boot? Let's try to pretend like this is a generic property and
> > just say "bootloader" :)
> > > @@ -445,6 +446,7 @@ flash@0 {
> > >   		cdns,tchsh-ns = <60>;
> > >   		cdns,tslch-ns = <60>;
> > >   		cdns,read-delay = <4>;
> > > +		bootph-all;
> 
> Here and elsewhere, follow:
> 	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117

Could you tell me what are you seeing wrong? The dts-coding-style that
you shared doesn't tell a specific location for bootph-* properties so
using the generic reasoning.

"1. Most important properties start the node: compatible then bus addressing to
   match unit address."

This is the least important property considering Linux and hence the
reasoning was that it should come in the last. Also, j722s and am62p
follow the same convention so it was taken from there only.

Regards,
Manorit

> 
> 
> > >   	};
> > >   };
> > > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D