linux-kernel - Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce4903f2-2a9d-45c4-bd4d-ac5165211a83@kernel.org>
Date: Wed, 7 Aug 2024 07:57:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yunhong Jiang <yunhong.jiang@...ux.intel.com>, tglx@...utronix.de,
 mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
 hpa@...or.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
 decui@...rosoft.com, rafael@...nel.org, lenb@...nel.org,
 kirill.shutemov@...ux.intel.com
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-hyperv@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox

On 07/08/2024 00:12, Yunhong Jiang wrote:
> Add the binding to use the ACPI wakeup mailbox mechanism to bringup APs.

We do not have bindings for ACPI. I think in the past it was mentioned
pretty clear - we do not care what ACPI has in the wild.

> 
> Signed-off-by: Yunhong Jiang <yunhong.jiang@...ux.intel.com>
> ---
>  .../devicetree/bindings/x86/wakeup.yaml       | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/x86/wakeup.yaml
> 
> diff --git a/Documentation/devicetree/bindings/x86/wakeup.yaml b/Documentation/devicetree/bindings/x86/wakeup.yaml
> new file mode 100644
> index 000000000000..8af40dcdb592
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/x86/wakeup.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +
> +$id: http://devicetree.org/schemas/x86/wakeup.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#

This was absolutely never tested and does not look like proper bindings
file. This just does not work. Go to example-schema and use it as template.

NAK

Best regards,
Krzysztof