linux-kernel - Re: [PATCH v4 24/26] arch_numa: switch over to numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1befc540-8904-4c23-b0e6-e2c556fe22b9@app.fastmail.com>
Date: Wed, 07 Aug 2024 08:58:37 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Mike Rapoport" <rppt@...nel.org>, linux-kernel@...r.kernel.org
Cc: "Alexander Gordeev" <agordeev@...ux.ibm.com>,
 "Andreas Larsson" <andreas@...sler.com>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Borislav Petkov" <bp@...en8.de>,
 "Catalin Marinas" <catalin.marinas@....com>,
 "Christophe Leroy" <christophe.leroy@...roup.eu>,
 "Dan Williams" <dan.j.williams@...el.com>,
 "Dave Hansen" <dave.hansen@...ux.intel.com>,
 "David Hildenbrand" <david@...hat.com>,
 "David S . Miller" <davem@...emloft.net>,
 "Davidlohr Bueso" <dave@...olabs.net>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Heiko Carstens" <hca@...ux.ibm.com>,
 "Huacai Chen" <chenhuacai@...nel.org>, "Ingo Molnar" <mingo@...hat.com>,
 "Jiaxun Yang" <jiaxun.yang@...goat.com>,
 "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
 "Jonathan Cameron" <jonathan.cameron@...wei.com>,
 "Jonathan Corbet" <corbet@....net>,
 "Michael Ellerman" <mpe@...erman.id.au>,
 "Palmer Dabbelt" <palmer@...belt.com>,
 "Rafael J . Wysocki" <rafael@...nel.org>,
 "Rob Herring" <robh@...nel.org>,
 "Samuel Holland" <samuel.holland@...ive.com>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Thomas Gleixner" <tglx@...utronix.de>,
 "Vasily Gorbik" <gor@...ux.ibm.com>, "Will Deacon" <will@...nel.org>,
 "Zi Yan" <ziy@...dia.com>, devicetree@...r.kernel.org,
 linux-acpi@...r.kernel.org, Linux-Arch <linux-arch@...r.kernel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-cxl@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-mips@...r.kernel.org,
 linux-mm@...ck.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, loongarch@...ts.linux.dev,
 nvdimm@...ts.linux.dev, sparclinux@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v4 24/26] arch_numa: switch over to numa_memblks

On Wed, Aug 7, 2024, at 08:41, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@...nel.org>
>
> Until now arch_numa was directly translating firmware NUMA information
> to memblock.

I get a link time warning from this:

    WARNING: modpost: vmlinux: section mismatch in reference: numa_set_cpumask+0x24 (section: .text.unlikely) -> early_cpu_to_node (section: .init.text)

> @@ -142,7 +144,7 @@ void __init early_map_cpu_to_node(unsigned int cpu, int nid)
>  unsigned long __per_cpu_offset[NR_CPUS] __read_mostly;
>  EXPORT_SYMBOL(__per_cpu_offset);
> 
> -int __init early_cpu_to_node(int cpu)
> +int early_cpu_to_node(int cpu)
>  {
>  	return cpu_to_node_map[cpu];
>  }

early_cpu_to_node() can no longer be __init here

> +#endif /* CONFIG_NUMA_EMU */
> diff --git a/include/asm-generic/numa.h b/include/asm-generic/numa.h
> index c32e0cf23c90..c2b046d1fd82 100644
> --- a/include/asm-generic/numa.h
> +++ b/include/asm-generic/numa.h
> @@ -32,8 +32,6 @@ static inline const struct cpumask *cpumask_of_node(int node)
> 
>  void __init arch_numa_init(void);
>  int __init numa_add_memblk(int nodeid, u64 start, u64 end);
> -void __init numa_set_distance(int from, int to, int distance);
> -void __init numa_free_distance(void);
>  void __init early_map_cpu_to_node(unsigned int cpu, int nid);
>  int __init early_cpu_to_node(int cpu);
>  void numa_store_cpu_info(unsigned int cpu);

but is still declared as __init in the header, so it is
still put in that section and discarded after boot.

I was confused by this at first, since the 'early' name
seems to imply that you shouldn't call it once the system
is up, but now you do.

     Arnd