[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <40031203-63c6-46b5-b647-d344d4503bb7@kernel.org>
Date: Wed, 7 Aug 2024 09:06:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Michael Nemanov <michael.nemanov@...com>, Kalle Valo <kvalo@...nel.org>,
"David S . Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Sabeeh Khan <sabeeh-khan@...com>
Subject: Re: [PATCH v3 17/17] dt-bindings: net: wireless: cc33xx: Add
ti,cc33xx.yaml
On 06/08/2024 19:00, Michael Nemanov wrote:
Thank you for your patch. There is something to discuss/improve.
> +properties:
> + compatible:
> + enum:
> + - ti,cc3300
> + - ti,cc3301
> + - ti,cc3350
> + - ti,cc3351
> +
> + reg:
> + description:
> + must be set to 2
Then just const: 2 and drop free form text.
> + maxItems: 1
> +
> + interrupts:
> + description:
> + The out-of-band interrupt line.
> + Can be IRQ_TYPE_EDGE_RISING or IRQ_TYPE_LEVEL_HIGH.
> + If property is omitted, SDIO in-band IRQ will be used.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + // SDIO example:
Drop, obvious.
> + mmc {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + wifi@1{
Missing space.
Also, this does not match reg. Test your DTS with W=1 and FIX ALL warnings.
Best regards,
Krzysztof
Powered by blists - more mailing lists