linux-kernel - Re: [PATCH] wifi: cfg80211: fix bug of mapping AF3x to incorrect User Priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ttfwiyn6.fsf@kernel.org>
Date: Wed, 07 Aug 2024 10:24:13 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Guillaume Nault <gnault@...hat.com>
Cc: Simon Horman <horms@...nel.org>,  hhorace <hhoracehsu@...il.com>,
  johannes@...solutions.net,  davem@...emloft.net,  edumazet@...gle.com,
  kuba@...nel.org,  pabeni@...hat.com,  linux-kernel@...r.kernel.org,
  linux-wireless@...r.kernel.org,  netdev@...r.kernel.org,  Ido Schimmel
 <idosch@...dia.com>
Subject: Re: [PATCH] wifi: cfg80211: fix bug of mapping AF3x to incorrect
 User Priority

Guillaume Nault <gnault@...hat.com> writes:

> On Tue, Aug 06, 2024 at 10:08:44AM +0100, Simon Horman wrote:
>> + Guillaume and Ido
>> 
>> On Mon, Aug 05, 2024 at 03:17:42PM +0800, hhorace wrote:
>> > According to RFC8325 4.3, Multimedia Streaming: AF31(011010, 26), 
>> > AF32(011100, 28), AF33(011110, 30) maps to User Priority = 4 
>> > and AC_VI (Video).
>> > 
>> > However, the original code remain the default three Most Significant
>> > Bits (MSBs) of the DSCP, which makes AF3x map to User Priority = 3
>> > and AC_BE (Best Effort).
>> > 
>> > Signed-off-by: hhorace <hhoracehsu@...il.com>
>> 
>> Adding Guillaume and Ido as this relates to DSCP.
>
> Thanks. The patch looks good to me (only missing a Fixes tag).
>
> Just a note to hhorace: the entry for CS5 (case 40) is useless as CS5
> is 101000. So the value of the 3 high order bits already is 5 (in case
> you want to make a followup patch for net-next).

Minor clarification: cfg80211 patches go to wireless-next, not net-next.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches