linux-kernel - Re: [PATCH v1 1/2] media: camss: Increase the maximum frame size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc9f87c4-d14b-46c8-8545-826c0a1ab6f6@linaro.org>
Date: Wed, 7 Aug 2024 09:16:36 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Jordan Crouse <jorcrous@...zon.com>, linux-media@...r.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Robert Foss
 <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] media: camss: Increase the maximum frame size

On 07/08/2024 00:09, Bryan O'Donoghue wrote:
>>
>> Also increase the maximum size checks at each point in the pipeline so
>> the increased sizes are allowed all the way down to the sensor.
> 
> So, I think this should be a Fixes: also.

TL;DR we don't need a Fixes: for your v2.

Pardon me, not a Fixes: the sizeof(sensor) that can be supported is SoC 
specific - camera IP specific really - so 8192 is a blunt descriptor, 
raising to 16384 makes some kind of sense.

A long term fix for this would be for each camss descriptor to declare 
the maximum sizeof(sensor) it supports. For sm8250, sc8280xp that's 64 
megapixels - for older SoCs its going to be smaller.

---
bod