[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240807010755.g4yde7vdgpu3lgsz@synopsys.com>
Date: Wed, 7 Aug 2024 01:08:00 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Frank Li <Frank.Li@....com>
CC: Mathias Nyman <mathias.nyman@...el.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
"jun.li@....com" <jun.li@....com>
Subject: Re: [PATCH 2/4] usb: dwc3: imx8mp: add 2 software managed quirk
properties for host mode
On Fri, Jul 12, 2024, Frank Li wrote:
> Add 2 software manage quirk properites (xhci-missing-cas-quirk and
> xhci-skip-phy-init-quirk) for xhci host.
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> drivers/usb/dwc3/dwc3-imx8mp.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
> index 8ee4480685031..5794bb75f7604 100644
> --- a/drivers/usb/dwc3/dwc3-imx8mp.c
> +++ b/drivers/usb/dwc3/dwc3-imx8mp.c
> @@ -144,6 +144,17 @@ static irqreturn_t dwc3_imx8mp_interrupt(int irq, void *_dwc3_imx)
> return IRQ_HANDLED;
> }
>
> +static int dwc3_imx8mp_set_software_node(struct device *dev)
> +{
> + struct property_entry props[3] = {};
To be safe, use props[3] = { 0 } initialization sematic so to keep
compatibility.
> + int prop_idx = 0;
> +.
> + props[prop_idx++] = PROPERTY_ENTRY_BOOL("xhci-missing-cas-quirk");
> + props[prop_idx++] = PROPERTY_ENTRY_BOOL("xhci-skip-phy-init-quirk");
> +
> + return device_create_managed_software_node(dev, props, NULL);
> +}
> +
> static int dwc3_imx8mp_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -226,6 +237,13 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
> goto disable_rpm;
> }
>
> + err = dwc3_imx8mp_set_software_node(dev);
> + if (err) {
> + err = -ENODEV;
> + dev_err(dev, "failed to create software node\n");
> + goto disable_rpm;
> + }
> +
> err = of_platform_populate(node, NULL, NULL, dev);
> if (err) {
> dev_err(&pdev->dev, "failed to create dwc3 core\n");
>
> --
> 2.34.1
>
The rest looks fine to me.
BR,
Thinh
Powered by blists - more mailing lists