linux-kernel - Re: [PATCH v3 4/5] arm64: dts: ti: k3-j721e*: Add bootph-* properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807094749.3fmaxjdptw43adem@uda0497581>
Date: Wed, 7 Aug 2024 15:17:49 +0530
From: Manorit Chawdhry <m-chawdhry@...com>
To: Neha Malcom Francis <n-francis@...com>
CC: Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Tero
 Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Aniket Limaye <a-limaye@...com>,
        Udit Kumar
	<u-kumar1@...com>, Beleswar Padhi <b-padhi@...com>,
        Siddharth Vadapalli
	<s-vadapalli@...com>
Subject: Re: [PATCH v3 4/5] arm64: dts: ti: k3-j721e*: Add bootph-* properties

Hi Neha,

On 14:54-20240807, Neha Malcom Francis wrote:
> Hi Manorit,
> 
> On 30/07/24 15:23, Manorit Chawdhry wrote:
> > Adds bootph-* properties to the leaf nodes to enable U-boot to
> > utilise them.
> > 
> > Signed-off-by: Manorit Chawdhry <m-chawdhry@...com>
> > ---
> >   .../arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 20 ++++++++++++++++++++
> >   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi            |  2 ++
> >   arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi      |  9 +++++++++
> >   arch/arm64/boot/dts/ti/k3-j721e-sk.dts               | 18 ++++++++++++++++++
> >   arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi          |  5 +++++
> >   5 files changed, 54 insertions(+)
> > 
[..]
> > @@ -440,6 +444,7 @@ &hbmc {
> >   	flash@0,0 {
> >   		compatible = "cypress,hyperflash", "cfi-flash";
> >   		reg = <0x00 0x00 0x4000000>;
> > +		bootph-all;
> >   		partitions {
> >   			compatible = "fixed-partitions";
> > 
> 
> Sanity boot tested on J721E-SK after porting to U-Boot. Thanks for the
> patch, along with the reviews made by Udit (although one additional mention:
> IIRC, OSPI partitions are cosmetic for the U-Boot driver, but better to add
> bootph even if it's cosmetic in case the driver changes the next day), with
> those addressed:
> 
> Reviewed-by: Neha Malcom Francis <n-francis@...com>

Would be following up on those comments. Thanks for reviewing and
testing!

Regards,
Manorit

> 
> -- 
> Thanking You
> Neha Malcom Francis