linux-kernel - Re: [PATCH 1/2] media: i2c: tvp5150: Constify struct regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8971804c-ea5f-4678-b874-2d41950aa448@xs4all.nl>
Date: Wed, 7 Aug 2024 12:00:26 +0200
From: Hans Verkuil <hverkuil@...all.nl>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Michael Tretter <m.tretter@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] media: i2c: tvp5150: Constify struct regmap_config

On 05/07/2024 12:53, Javier Carrasco wrote:
> `tvp5150_config` is not modified and can be declared as const to
> move its data to a read-only section.

This is a duplicate of:

https://patchwork.linuxtv.org/project/linux-media/patch/119b3ec62e6305c83ffadc7f40cbda9fc3d5be11.1714893773.git.christophe.jaillet@wanadoo.fr/

I'll take that one since that also constifies i2c_vbi_ram_value.

Regards,

	Hans

> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  drivers/media/i2c/tvp5150.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 64b91aa3c82a..3205ecd60281 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -1812,7 +1812,7 @@ static const struct regmap_access_table tvp5150_readable_table = {
>  	.n_yes_ranges = ARRAY_SIZE(tvp5150_readable_ranges),
>  };
>  
> -static struct regmap_config tvp5150_config = {
> +static const struct regmap_config tvp5150_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
>  	.max_register = 0xff,
>