[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACZJ9cXcm+he98NTr8RiuZygvhZ6CtoOXFkASeLC4RQLk3Xqsg@mail.gmail.com>
Date: Wed, 7 Aug 2024 18:38:18 +0800
From: Liam Ni <zhiguangni01@...il.com>
To: Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>,
Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>
Cc: x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] KVM:x86:Fix an interrupt injection logic error during
PIC interrupt simulation
frendly ping
On Tue, 30 Jul 2024 at 21:59, Liam Ni <zhiguangni01@...il.com> wrote:
>
> The input parameter level to the pic_irq_request function indicates
> whether there are interrupts to be injected,
> a level value of 1 indicates that there are interrupts to be injected,
> and a level value of 0 indicates that there are no interrupts to be injected.
> And the value of level will be assigned to s->output,
> so we should set s->wakeup_needed to true when s->output is true.
>
> Signed-off-by: Liam Ni <zhiguangni01@...il.com>
> ---
> arch/x86/kvm/i8259.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
> index 8dec646e764b..ec9d6ee7d33d 100644
> --- a/arch/x86/kvm/i8259.c
> +++ b/arch/x86/kvm/i8259.c
> @@ -567,7 +567,7 @@ static void pic_irq_request(struct kvm *kvm, int level)
> {
> struct kvm_pic *s = kvm->arch.vpic;
>
> - if (!s->output)
> + if (!s->output && level)
> s->wakeup_needed = true;
> s->output = level;
> }
> --
> 2.34.1
Powered by blists - more mailing lists