linux-kernel - Re: [PATCH 0/2] tty: serial: samsung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71e73974d0c3ce99e46ed85a42742a8d46e53c73.camel@linaro.org>
Date: Wed, 07 Aug 2024 12:17:31 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Alim Akhtar
 <alim.akhtar@...sung.com>,  Jiri Slaby <jirislaby@...nel.org>, Peter
 Griffin <peter.griffin@...aro.org>, Tudor Ambarus
 <tudor.ambarus@...aro.org>, Will McVicker <willmcvicker@...gle.com>, 
 kernel-team@...roid.com, linux-arm-kernel@...ts.infradead.org, 
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-serial@...r.kernel.org
Subject: Re: [PATCH 0/2] tty: serial: samsung_tty: simple cleanups

On Wed, 2024-08-07 at 13:09 +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 06, 2024 at 04:29:44PM +0100, André Draszik wrote:
> > While looking through the samsung tty driver, I've spotted a few things that
> > can be simplified by removing unused function arguments and by avoiding some
> > duplicated variables and casting.
> > 
> > There are no functional changes here.
> > 
> > Signed-off-by: André Draszik <andre.draszik@...aro.org>
> > ---
> > André Draszik (2):
> >       tty: serial: samsung_tty: drop unused argument to irq handlers
> >       tty: serial: samsung_tty: cast the interrupt's void *id just once
> 
> This series blows up the build for me, are you sure you tested it?
> 
> drivers/tty/serial/samsung_tty.c: In function ‘s3c64xx_serial_handle_irq’:
> drivers/tty/serial/samsung_tty.c:948:45: error: passing argument 1 of ‘s3c24xx_serial_rx_irq’ discards ‘const’ qualifier from pointer
> target type [-Werror=discarded-qualifiers]
>   948 |                 ret = s3c24xx_serial_rx_irq(ourport);
>       |                                             ^~~~~~~
> drivers/tty/serial/samsung_tty.c:856:68: note: expected ‘struct s3c24xx_uart_port *’ but argument is of type ‘const struct
> s3c24xx_uart_port *’
> 
> And so on...

Odd, I did test this, yes. Not sure why I don't get these, let me check.

Cheers,
Andre'