linux-kernel - Re: [PATCH v3 1/5] arm64: dts: ti: k3-j721s2*: Add bootph-* properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807114947.tvkpo4k2ggncxcce@scouts>
Date: Wed, 7 Aug 2024 06:49:47 -0500
From: Nishanth Menon <nm@...com>
To: Manorit Chawdhry <m-chawdhry@...com>
CC: Neha Malcom Francis <n-francis@...com>, Andrew Davis <afd@...com>,
        Vignesh
 Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Aniket Limaye
	<a-limaye@...com>,
        Udit Kumar <u-kumar1@...com>, Beleswar Padhi
	<b-padhi@...com>,
        Siddharth Vadapalli <s-vadapalli@...com>
Subject: Re: [PATCH v3 1/5] arm64: dts: ti: k3-j721s2*: Add bootph-*
 properties

On 12:06-20240807, Manorit Chawdhry wrote:
[...]

> > > > 
> > > > Not sure if this is what he meant, but bootph-* comes under standard/common
> > > > properties as per my understanding of the coding style. And status needs to
> > > > be at the very end if it's there (in this case it's not but just
> > > > mentioning).
> > > 
> > > I see status property being at the top of many nodes so I don't think
> > > it's even followed right now, with that reasoning, I don't think I can
> > > use that point for ordering the dt nodes. If it's under common nodes
> > > then also I think it's in the appropriate location considering that even
> > > in those properties it is the least important and should be coming in
> > > the last. If you see any problem with this node then please let me know
> > > in the ordering.
> > > 
> > 
> > Aren't cdns,-* vendor specific properties?
> > 
> > Also I understand that most DTS aren't following majority of the rules, but
> > considering it was a review comment I assume they want a check on what goes
> > in at least so I've mentioned what I think they're asking for.
> 
> I can fix it in places where it can be fixed ( I see few places where
> order exist ) but where there is no order there this will be difficult
> to handle. That'd require a total fix for ordering across all the places
> and that will require a separate cleanup ig. So if people are okay, in
> those places I'll be keeping bootph-* in the last like how it's followed
> in right now.

Just make sure that when new properties or nodes are introduced, follow
the convention. For new SoCs, this is mandatory for new nodes that are
introduced (not when renaming file etc).

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D