linux-kernel - Re: [PATCH] ASoC: cs43130: Constify struct reg_sequence and reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrNjAdV7wG1SvX9G@opensource.cirrus.com>
Date: Wed, 7 Aug 2024 13:05:21 +0100
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC: David Rhodes <david.rhodes@...rus.com>,
        Richard Fitzgerald
	<rf@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <linux-sound@...r.kernel.org>
Subject: Re: [PATCH] ASoC: cs43130: Constify struct reg_sequence and
 reg_sequences

On Tue, Aug 06, 2024 at 03:43:00PM +0200, Christophe JAILLET wrote:
> 'struct reg_sequence' and 'struct reg_sequences' are not modified in this
> drivers.
> 
> Constifying these structures moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   54409	   7881	     64	  62354	   f392	sound/soc/codecs/cs43130.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   55562	   6729	     64	  62355	   f393	sound/soc/codecs/cs43130.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles