[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOf5uwkhThmTEuhYAxAgLqg86PEHJ49wWp67RahVhio=O2OfQw@mail.gmail.com>
Date: Wed, 7 Aug 2024 14:38:51 +0200
From: Michael Nazzareno Trimarchi <michael@...rulasolutions.com>
To: neil.armstrong@...aro.org, Doug Anderson <dianders@...omium.org>
Cc: quic_jesszhan@...cinc.com, sam@...nborg.org, mripard@...nel.org,
tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] drm/panel: synaptics-r63353: Fix regulator unbalance
Hi Doug
+cc Doug
I have seen that you have done some re-working and investigation on
drm stack, do you have some
suggestion on this case?
On Mon, Jun 24, 2024 at 8:53 PM Michael Trimarchi
<michael@...rulasolutions.com> wrote:
>
> The shutdown function can be called when the display is already
> unprepared. For example during reboot this trigger a kernel
> backlog. Calling the drm_panel_unprepare, allow us to avoid
> to trigger the kernel warning
>
> Signed-off-by: Michael Trimarchi <michael@...rulasolutions.com>
> ---
>
> It's not obviovus if shutdown can be dropped or this problem depends
> on the display stack as it is implmented. More feedback is required
> here
>
> ---
> drivers/gpu/drm/panel/panel-synaptics-r63353.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c
> index 169c629746c7..17349825543f 100644
> --- a/drivers/gpu/drm/panel/panel-synaptics-r63353.c
> +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c
> @@ -325,7 +325,7 @@ static void r63353_panel_shutdown(struct mipi_dsi_device *dsi)
> {
> struct r63353_panel *rpanel = mipi_dsi_get_drvdata(dsi);
>
> - r63353_panel_unprepare(&rpanel->base);
> + drm_panel_unprepare(&rpanel->base);
> }
>
> static const struct r63353_desc sharp_ls068b3sx02_data = {
> --
> 2.43.0
>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@...rulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@...rulasolutions.com
www.amarulasolutions.com
Powered by blists - more mailing lists