[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZrNrtx1qvPYatpsw@linaro.org>
Date: Wed, 7 Aug 2024 14:42:31 +0200
From: Stephan Gerhold <stephan.gerhold@...aro.org>
To: Rob Clark <robdclark@...il.com>
Cc: linux-arm-msm@...r.kernel.org, Abel Vesa <abel.vesa@...aro.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Rob Clark <robdclark@...omium.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] arm64: dts: qcom: x1e80100-yoga: Update panel bindings
On Tue, Aug 06, 2024 at 01:22:17PM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@...omium.org>
>
> Use the correct panel compatible, and wire up enable-gpio. It is wired
> up in the same way as the x1e80100-crd.
>
> Signed-off-by: Rob Clark <robdclark@...omium.org>
> Reviewed-by: Abel Vesa <abel.vesa@...aro.org>
Reviewed-by: Stephan Gerhold <stephan.gerhold@...aro.org>
Thanks for the update!
> ---
> Corresponding schema update is in drm-misc-fixes
>
> [1/2] dt-bindings: display: panel: samsung,atna45dc02: Document ATNA45DC02
> commit: 1c4a057d01f4432704c4dc8842b6e888a91d95df
>
> .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> index 70977e9fa266..3c13331a9ef4 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> @@ -190,7 +190,6 @@ vreg_edp_3p3: regulator-edp-3p3 {
> pinctrl-0 = <&edp_reg_en>;
> pinctrl-names = "default";
>
> - regulator-always-on;
> regulator-boot-on;
> };
>
> @@ -592,9 +591,13 @@ &mdss_dp3 {
>
> aux-bus {
> panel {
> - compatible = "edp-panel";
> + compatible = "samsung,atna45dc02", "samsung,atna33xc20";
> + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
> power-supply = <&vreg_edp_3p3>;
>
> + pinctrl-0 = <&edp_bl_en>;
> + pinctrl-names = "default";
> +
> port {
> edp_panel_in: endpoint {
> remote-endpoint = <&mdss_dp3_out>;
> @@ -669,6 +672,16 @@ &pcie6a_phy {
> status = "okay";
> };
>
> +&pmc8380_3_gpios {
> + edp_bl_en: edp-bl-en-state {
> + pins = "gpio4";
> + function = "normal";
> + power-source = <0>;
> + input-disable;
> + output-enable;
> + };
> +};
> +
> &qupv3_0 {
> status = "okay";
> };
> --
> 2.45.2
>
Powered by blists - more mailing lists