linux-kernel - Re: [PATCH net-next] eventpoll: Don't re-zero eventpoll fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807125633.dlwr6rx6yzl4ippv@quack3>
Date: Wed, 7 Aug 2024 14:56:33 +0200
From: Jan Kara <jack@...e.cz>
To: Joe Damato <jdamato@...tly.com>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, sdf@...gle.com, edumazet@...gle.com,
	kuba@...nel.org, mkarsten@...terloo.ca,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH net-next] eventpoll: Don't re-zero eventpoll fields

On Wed 07-08-24 10:52:31, Joe Damato wrote:
> Remove redundant and unnecessary code.
> 
> ep_alloc uses kzalloc to create struct eventpoll, so there is no need to
> set fields to defaults of 0. This was accidentally introduced in commit
> 85455c795c07 ("eventpoll: support busy poll per epoll instance") and
> expanded on in follow-up commits.
> 
> Signed-off-by: Joe Damato <jdamato@...tly.com>
> Reviewed-by: Martin Karsten <mkarsten@...terloo.ca>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/eventpoll.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/fs/eventpoll.c b/fs/eventpoll.c
> index f53ca4f7fced..6c0a1e9715ea 100644
> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c
> @@ -2200,11 +2200,6 @@ static int do_epoll_create(int flags)
>  		error = PTR_ERR(file);
>  		goto out_free_fd;
>  	}
> -#ifdef CONFIG_NET_RX_BUSY_POLL
> -	ep->busy_poll_usecs = 0;
> -	ep->busy_poll_budget = 0;
> -	ep->prefer_busy_poll = false;
> -#endif
>  	ep->file = file;
>  	fd_install(fd, file);
>  	return fd;
> -- 
> 2.25.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR