linux-kernel - Re: [PATCH net-next] net: sungem_phy: Constify struct mii_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34d55ac2-83ca-4463-bfb6-35e431340df7@lunn.ch>
Date: Wed, 7 Aug 2024 15:57:51 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: sungem_phy: Constify struct mii_phy_def

On Wed, Aug 07, 2024 at 02:22:26PM +0200, Christophe JAILLET wrote:
> 'struct mii_phy_def' are not modified in this driver.
> 
> Constifying these structures moves some data to a read-only section, so
> increase overall security.
> 
> While at it fix the checkpatch warning related to this patch (some missing
> newlines and spaces around *)
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
>   27709	    928	      0	  28637	   6fdd	drivers/net/sungem_phy.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   28157	    476	      0	  28633	   6fd9	drivers/net/sungem_phy.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew