[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZrN+affnZLC2CmEl@lizhi-Precision-Tower-5810>
Date: Wed, 7 Aug 2024 10:02:17 -0400
From: Frank Li <Frank.li@....com>
To: Csókás, Bence <csokas.bence@...lan.hu>
Cc: imx@...ts.linux.dev, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, Wei Fang <wei.fang@....com>,
Shenwei Wang <shenwei.wang@....com>,
Clark Wang <xiaoning.wang@....com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH resubmit net 2/2] net: fec: Remove duplicated code
On Wed, Aug 07, 2024 at 10:29:19AM +0200, Csókás, Bence wrote:
> `fec_ptp_pps_perout()` reimplements logic already
> in `fec_ptp_read()`. Replace with function call.
>
> Signed-off-by: Csókás, Bence <csokas.bence@...lan.hu>
Reviewed-by: Frank Li <Frank.Li@....com>
> ---
> drivers/net/ethernet/freescale/fec_ptp.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
> index fdbf61069a05..91b0804142e4 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -213,13 +213,7 @@ static int fec_ptp_pps_perout(struct fec_enet_private *fep)
> timecounter_read(&fep->tc);
>
> /* Get the current ptp hardware time counter */
> - temp_val = readl(fep->hwp + FEC_ATIME_CTRL);
> - temp_val |= FEC_T_CTRL_CAPTURE;
> - writel(temp_val, fep->hwp + FEC_ATIME_CTRL);
> - if (fep->quirks & FEC_QUIRK_BUG_CAPTURE)
> - udelay(1);
> -
> - ptp_hc = readl(fep->hwp + FEC_ATIME);
> + ptp_hc = fec_ptp_read(&fep->cc);
>
> /* Convert the ptp local counter to 1588 timestamp */
> curr_time = timecounter_cyc2time(&fep->tc, ptp_hc);
> --
> 2.34.1
>
>
Powered by blists - more mailing lists