linux-kernel - Re: [PATCH 0/3] pinctrl: meson: Constify some structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1jy158xvwz.fsf@starbuckisacylon.baylibre.com>
Date: Wed, 07 Aug 2024 16:14:04 +0200
From: Jerome Brunet <jbrunet@...libre.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linus.walleij@...aro.org,  neil.armstrong@...aro.org,
  khilman@...libre.com,  martin.blumenstingl@...glemail.com,
  linux-gpio@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
  linux-amlogic@...ts.infradead.org,  linux-kernel@...r.kernel.org,
  kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 0/3] pinctrl: meson: Constify some structure

On Wed 07 Aug 2024 at 11:30, Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> These 3 patches constify some structures in order to move some data to a
> read-only section, so increase overall security.
>
> It is splitted in 3 to ease review.

I'm not entirely sure it eases review in this case.
If a v2 is necessary, I think a single patch would be better.

> Patch 1: struct meson_pmx_group and meson_pmx_func
> patch 2: struct meson_bank
> patch 3: struct meson_pmx_bank

Is there any reason for leaving out 'struct meson_pinctrl_data' and
'struct meson_axg_pmx_data' ? I don't think they get modified but maybe
I missed it.

>
> All patches are only compile tested.

Looks good anyway
Reviewed-by: Jerome Brunet <jbrunet@...libre.com>

On the vim3l:
Tested-by: Jerome Brunet <jbrunet@...libre.com>