linux-kernel - Re: [net-next v3 05/15] net: cavium/liquidio: Convert tasklet API to new bottom half workqueue mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807073752.01bce1d2@kernel.org>
Date: Wed, 7 Aug 2024 07:37:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Allen <allen.lkml@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 jes@...ined-monkey.org, kda@...ux-powerpc.org, cai.huoqing@...ux.dev,
 dougmill@...ux.ibm.com, npiggin@...il.com, christophe.leroy@...roup.eu,
 aneesh.kumar@...nel.org, naveen.n.rao@...ux.ibm.com, nnac123@...ux.ibm.com,
 tlfalcon@...ux.ibm.com, cooldavid@...ldavid.org, marcin.s.wojtas@...il.com,
 mlindner@...vell.com, stephen@...workplumber.org, nbd@....name,
 sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com, lorenzo@...nel.org,
 matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
 borisp@...dia.com, bryan.whitehead@...rochip.com,
 UNGLinuxDriver@...rochip.com, louis.peens@...igine.com,
 richardcochran@...il.com, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-acenic@...site.dk,
 linux-net-drivers@....com, netdev@...r.kernel.org, Sunil Goutham
 <sgoutham@...vell.com>
Subject: Re: [net-next v3 05/15] net: cavium/liquidio: Convert tasklet API
 to new bottom half workqueue mechanism

On Tue, 6 Aug 2024 20:15:50 -0700 Allen wrote:
> In the context of of the driver, the conversion from tasklet_enable()
> to enable_and_queue_work() is correct because the callback function
> associated with the work item is designed to be safe even if there
> is no immediate work to process. The callback function can handle
> being invoked in such situations without causing errors or undesirable
> behavior. This makes the workqueue approach a suitable and safe
> replacement for the current tasklet mechanism, as it provides the
> necessary flexibility and ensures that the work item is properly
> scheduled and executed.

Fewer words, clearer indication that you read the code would be better
for the reviewer. Like actually call out what in the code makes it safe.

Just to be clear -- conversions to enable_and_queue_work() will require
manual inspection in every case.