linux-kernel - Re: [PATCH v3 03/17] wifi: cc33xx: Add sdio.c, io.c, io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68d0852a-2390-4fe4-be16-3f691e99bd86@ti.com>
Date: Wed, 7 Aug 2024 17:55:16 +0300
From: "Nemanov, Michael" <michael.nemanov@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Kalle Valo <kvalo@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Rob
 Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor
 Dooley <conor+dt@...nel.org>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC: Sabeeh Khan <sabeeh-khan@...com>
Subject: Re: [PATCH v3 03/17] wifi: cc33xx: Add sdio.c, io.c, io.h

On 8/7/2024 10:12 AM, Krzysztof Kozlowski wrote:



>> +static const struct of_device_id cc33xx_sdio_of_match_table[] = {
>> +	{ .compatible = "ti,cc3300", .data = &cc33xx_data },
>> +	{ .compatible = "ti,cc3301", .data = &cc33xx_data },
>> +	{ .compatible = "ti,cc3350", .data = &cc33xx_data },
>> +	{ .compatible = "ti,cc3351", .data = &cc33xx_data },
>> +	{ }
>> +};
> 
> 
> Eh? What happened here? So devices are compatibles thus make them
> compatible in the bindings.
> 

I thought this is the right way to do it (originally taken from [1]).
How can I solve it via DT bindings?

> 
>> +
>> +module_param(dump, bool, 0600);
>> +MODULE_PARM_DESC(dump, "Enable sdio read/write dumps.");
> 
> This should be rather debug interface, not module param.
> 

Meaning debugFS?

Thanks and regards,
Michael.


[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wireless/ti/wlcore/sdio.c#n204