[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <167bbcf1-8d44-41d7-102f-4e8f1adc1519@quicinc.com>
Date: Thu, 8 Aug 2024 13:09:51 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Kees Cook <kees@...nel.org>,
Stanimir Varbanov
<stanimir.k.varbanov@...il.com>
CC: Vikash Garodia <quic_vgarodia@...cinc.com>,
Bryan O'Donoghue
<bryan.odonoghue@...aro.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>,
<linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<linux-hardening@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] media: venus: hfi_cmds: struct
hfi_session_release_buffer_pkt: Add __counted_by annotation
On 7/11/2024 4:39 AM, Kees Cook wrote:
> The only direct user of struct hfi_session_release_buffer_pkt is
> pkt_session_unset_buffers() which sets "num_buffers" before using it
> as a loop counter for accessing "buffer_info". Add the __counted_by
> annotation to reflect the relationship.
>
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Stanimir Varbanov <stanimir.k.varbanov@...il.com>
> Cc: Vikash Garodia <quic_vgarodia@...cinc.com>
> Cc: "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>
> Cc: linux-media@...r.kernel.org
> Cc: linux-arm-msm@...r.kernel.org
> Cc: linux-hardening@...r.kernel.org
> ---
> drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h
> index 42825f07939d..1adf2d2ae5f2 100644
> --- a/drivers/media/platform/qcom/venus/hfi_cmds.h
> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h
> @@ -227,7 +227,7 @@ struct hfi_session_release_buffer_pkt {
> u32 extradata_size;
> u32 response_req;
> u32 num_buffers;
> - u32 buffer_info[];
> + u32 buffer_info[] __counted_by(num_buffers);
> };
>
> struct hfi_session_release_resources_pkt {
Reviewed-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
Thanks,
Dikshita
Powered by blists - more mailing lists