linux-kernel - Re: [PATCH v4 8/8] reset: mchp: sparx5: set the dev member of the reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f97296c967211a6a8f6f40996e3ed74b76bad935.camel@microchip.com>
Date: Thu, 8 Aug 2024 10:22:23 +0200
From: Steen Hegelund <steen.hegelund@...rochip.com>
To: Herve Codina <herve.codina@...tlin.com>, Geert Uytterhoeven
	<geert@...ux-m68k.org>, Andy Shevchenko <andy.shevchenko@...il.com>, "Simon
 Horman" <horms@...nel.org>, Lee Jones <lee@...nel.org>, Arnd Bergmann
	<arnd@...db.de>, Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic
	<dragan.cvetic@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Philipp Zabel <p.zabel@...gutronix.de>,
	Lars Povlsen <lars.povlsen@...rochip.com>, Daniel Machon
	<daniel.machon@...rochip.com>, <UNGLinuxDriver@...rochip.com>, Rob Herring
	<robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Horatiu Vultur <horatiu.vultur@...rochip.com>, "Andrew
 Lunn" <andrew@...n.ch>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>, "Allan
 Nielsen" <allan.nielsen@...rochip.com>, Luca Ceresoli
	<luca.ceresoli@...tlin.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Clément Léger <clement.leger@...tlin.com>
Subject: Re: [PATCH v4 8/8] reset: mchp: sparx5: set the dev member of the
 reset controller

Hi Herve,

On Mon, 2024-08-05 at 12:17 +0200, Herve Codina wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> From: Clément Léger <clement.leger@...tlin.com>
> 
> In order to guarantee the device will not be deleted by the reset
> controller consumer, set the dev member of the reset controller.
> 
> Signed-off-by: Clément Léger <clement.leger@...tlin.com>
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> ---
>  drivers/reset/reset-microchip-sparx5.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/reset/reset-microchip-sparx5.c
> b/drivers/reset/reset-microchip-sparx5.c
> index c4fe65291a43..1ef2aa1602e3 100644
> --- a/drivers/reset/reset-microchip-sparx5.c
> +++ b/drivers/reset/reset-microchip-sparx5.c
> @@ -117,6 +117,7 @@ static int mchp_sparx5_reset_probe(struct
> platform_device *pdev)
>                 return err;
> 
>         ctx->rcdev.owner = THIS_MODULE;
> +       ctx->rcdev.dev = &pdev->dev;
>         ctx->rcdev.nr_resets = 1;
>         ctx->rcdev.ops = &sparx5_reset_ops;
>         ctx->rcdev.of_node = dn;
> --
> 2.45.0
> 

Looks good to me.

Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

BR
Steen