linux-kernel - Re: [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06648b4f-c606-06fb-0b9d-945a51f9a297@quicinc.com>
Date: Fri, 9 Aug 2024 10:36:22 -0600
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Lizhi Hou <lizhi.hou@....com>, <ogabbay@...nel.org>,
        <dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <min.ma@....com>, <max.zhen@....com>,
        <sonal.santan@....com>, <king.tam@....com>
Subject: Re: [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver

On 8/5/2024 11:39 AM, Lizhi Hou wrote:

> +int aie2_max_col = XRS_MAX_COL;
> +module_param(aie2_max_col, int, 0600);
> +MODULE_PARM_DESC(aie2_max_col, "Maximum column could be used");

I think you selected the wrong type.  What happens if someone sets this 
to a negative value?