linux-kernel - Re: [PATCH V2 09/10] accel/amdxdna: Add query functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f79b66c-89fa-ce78-e34b-294df1d9d1a0@quicinc.com>
Date: Fri, 9 Aug 2024 10:42:53 -0600
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Lizhi Hou <lizhi.hou@....com>, <ogabbay@...nel.org>,
        <dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <min.ma@....com>, <max.zhen@....com>,
        <sonal.santan@....com>, <king.tam@....com>
Subject: Re: [PATCH V2 09/10] accel/amdxdna: Add query functions

On 8/5/2024 11:39 AM, Lizhi Hou wrote:
> +/**
> + * struct amdxdna_drm_query_hwctx - The data for single context.
> + * @context_id: The ID for this context.
> + * @start_col: The starting column for the partition assigned to this context.
> + * @num_col: The number of columns in the partition assigned to this context.
> + * @pid: The Process ID of the process that created this context.
> + * @command_submissions: The number of commands submitted to this context.
> + * @command_completions: The number of commands completed by this context.
> + * @migrations: The number of times this context has been moved to a different partition.
> + * @preemptions: The number of times this context has been preempted by another context in the
> + *               same partition.
> + * @pad: MBZ.

Did you make the documentation?  This looks like it'll generate errors 
from missing fields, and not having the same order as the struct.

> + */
> +struct amdxdna_drm_query_hwctx {
> +	__u32 context_id;
> +	__u32 start_col;
> +	__u32 num_col;
> +	__u32 pad;
> +	__s64 pid;
> +	__u64 command_submissions;
> +	__u64 command_completions;
> +	__u64 migrations;
> +	__u64 preemptions;
> +	__u64 errors;
> +};