linux-kernel - Re: [PATCH] accel: drm_accel: remove incorrect comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54cdd823-98cc-ae67-c824-fad664e796a6@quicinc.com>
Date: Fri, 9 Aug 2024 10:52:45 -0600
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: bajing <bajing@...s.chinamobile.com>, <ogabbay@...nel.org>
CC: <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] accel: drm_accel: remove incorrect comments

On 7/31/2024 12:42 AM, bajing wrote:
> accel_minor_replace is of type void, so remove the explanation of the return value in the comments.
> 
> Signed-off-by: bajing <bajing@...s.chinamobile.com>
> ---
>   drivers/accel/drm_accel.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
> index 16c3edb8c46e..09fb64444cc6 100644
> --- a/drivers/accel/drm_accel.c
> +++ b/drivers/accel/drm_accel.c
> @@ -161,8 +161,6 @@ void accel_minor_remove(int index)
>    * This function access the accel minors idr structure and replaces the pointer
>    * that is associated with an existing id. Because the minor pointer can be
>    * NULL, we need to explicitly pass the index.
> - *
> - * Return: 0 for success, negative value for error
>    */
>   void accel_minor_replace(struct drm_minor *minor, int index)
>   {

Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>