linux-kernel - Re: [PATCH] rtla/osnoise: prevent NULL dereference in error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240809140545.698f654e@gandalf.local.home>
Date: Fri, 9 Aug 2024 14:05:45 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: John Kacur <jkacur@...hat.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, Daniel Bristot de Oliveira
 <bristot@...nel.org>, "Luis Claudio R. Goncalves" <lgoncalv@...hat.com>,
 Clark Williams <williams@...hat.com>, linux-trace-kernel@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] rtla/osnoise: prevent NULL dereference in error
 handling

On Fri, 9 Aug 2024 13:53:33 -0400 (EDT)
John Kacur <jkacur@...hat.com> wrote:

> > > Although your fix appears to be correct, I wonder if it would be better to 
> > > create a second error label, such as out_destroy_tool: as described in 
> > > section 7 of the coding-style.rst
> > >   
> > 
> > There's no reason for that. It's the only error path. That is, nothing
> > would jump to the original out_err:
> > 
> > And for a single error, an if statement is good enough.
> > 
> > -- Steve
> > 
> >   
> 
> Ah, right of course.
> Okay in that case, Signed-off-by: John Kacur <jkacur@...hat.com>
> (applied the patch, built and ran)

Note, "Signed-off-by" is for the author of a patch or someone pushing it
through their tree. I believe you want either "Acked-by" or "Reviewed-by",
and since you ran it you could also add "Tested-by".

-- Steve