linux-kernel - Re: [PATCH v3 1/2] dt-bindings: PCI: xilinx-xdma: Add schemas for Xilinx QDMA PCIe Root Port Bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240809181007.GA967711-robh@kernel.org>
Date: Fri, 9 Aug 2024 12:10:07 -0600
From: Rob Herring <robh@...nel.org>
To: Thippeswamy Havalige <thippesw@....com>
Cc: lpieralisi@...nel.org, kw@...ux.com, bhelgaas@...gle.com,
	krzk+dt@...nel.org, conor+dt@...nel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-pci@...r.kernel.org, thippeswamy.havalige@....com,
	linux-arm-kernel@...ts.infradead.org, michal.simek@....com
Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: xilinx-xdma: Add schemas for
 Xilinx QDMA PCIe Root Port Bridge

On Fri, Aug 09, 2024 at 11:39:54AM +0530, Thippeswamy Havalige wrote:
> Add YAML devicetree schemas for Xilinx QDMA Soft IP PCIe Root Port
> Bridge.
> 
> Signed-off-by: Thippeswamy Havalige <thippesw@....com>
> ---
>  .../devicetree/bindings/pci/xlnx,xdma-host.yaml    | 36 ++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)
> ---
> changes in v3
> - constrain the new entry to only the new compatible.
> - Remove example.
> 
> changes in v2
> - update dt node label with pcie.
> ---
> diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> index 2f59b3a..f1efd919 100644
> --- a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> @@ -14,10 +14,21 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: xlnx,xdma-host-3.00
> +    enum:
> +      - xlnx,xdma-host-3.00
> +      - xlnx,qdma-host-3.00

Kind of odd that both IP have the exact same version number. Please 
explain in the commit message where it comes from. If you just copied it 
from the previous one, then nak.

>  
>    reg:
> -    maxItems: 1
> +    items:
> +      - description: configuration region and XDMA bridge register.
> +      - description: QDMA bridge register.
> +    minItems: 1
> +
> +  reg-names:
> +    items:
> +      - const: cfg
> +      - const: breg
> +    minItems: 1
>  
>    ranges:
>      maxItems: 2
> @@ -76,6 +87,27 @@ required:
>    - "#interrupt-cells"
>    - interrupt-controller
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - xlnx,qdma-host-3.00
> +then:
> +  properties:
> +    reg:
> +      minItems: 2
> +    reg-names:
> +      minItems: 2
> +  required:
> +    - reg-names
> +else:
> +  properties:
> +    reg:
> +      maxItems: 1
> +    reg-names:
> +      maxItems: 1
> +
>  unevaluatedProperties: false
>  
>  examples:
> -- 
> 1.8.3.1
>