linux-kernel - Re: [PATCH v2 1/3] lockdep: fix upper limit for LOCKDEP_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrZlY-5h5N28PMH7@google.com>
Date: Fri, 9 Aug 2024 18:52:19 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: "J. R. Okajima" <hooanon05g@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
	kernel-team@...roid.com, Peter Zijlstra <peterz@...radead.org>,
	Boqun Feng <boqun.feng@...il.com>, Ingo Molnar <mingo@...hat.com>,
	Waiman Long <longman@...hat.com>, Will Deacon <will@...nel.org>
Subject: Re: [PATCH v2 1/3] lockdep: fix upper limit for LOCKDEP_*_BITS
 configs

On Thu, Aug 08, 2024 at 10:20:58AM +0900, J. R. Okajima wrote:
> Carlos Llamas:
> > Adjust the upper limits to the maximum values that avoid these issues.
> > The need for anything more, likely points to a problem elsewhere. Note
> > that LOCKDEP_CHAINS_BITS was intentionally left out as its upper limit
> > had a different symptom and has already been fixed [1].
> 
> I tried setting all these configs to maximum, but still I got the error.
> 	ld: kernel image bigger than KERNEL_IMAGE_SIZE
> 
> For me, these are the maximum.
> They are compilable, but could not boot due to "out of memory".
> Also I am not sure whether these values are meaningful.
> 
> CONFIG_LOCKDEP_BITS=23
> (CONFIG_LOCKDEP_CHAINS_BITS=21)
> CONFIG_LOCKDEP_STACK_TRACE_BITS=25
> CONFIG_LOCKDEP_STACK_TRACE_HASH_BITS=24
> CONFIG_LOCKDEP_CIRCULAR_QUEUE_BITS=22

Yeah, I say that's expected if you bump these values to the max all at
once. The values I gave were tested individually on top of the defconfig
and boot completed fine (qemu x86_64 and aarch64 with -m 8G). I think
it's fair to leave room to configure these knobs individually.

--
Carlos Llamas

> 
> J. R. Okajima