linux-kernel - Re: [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrZ3nm2U5ox3a25O@google.com>
Date: Fri, 9 Aug 2024 20:10:06 +0000
From: Pranjal Shrivastava <praan@...gle.com>
To: Rob Clark <robdclark@...il.com>
Cc: iommu@...ts.linux.dev, Rob Clark <robdclark@...omium.org>,
	Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
	Joerg Roedel <joro@...tes.org>, Jason Gunthorpe <jgg@...pe.ca>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Georgi Djakov <quic_c_gdjako@...cinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	"moderated list:ARM SMMU DRIVERS" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu/arm-smmu: Un-demote unhandled-fault msg

On Fri, Aug 09, 2024 at 10:27:14AM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@...omium.org>
> 
> Previously this was dev_err_ratelimited() but it got changed to a
> ratelimited dev_dbg().  Change it back to dev_err().
> 
> Fixes: d525b0af0c3b ("iommu/arm-smmu: Pretty-print context fault related regs")
> Signed-off-by: Rob Clark <robdclark@...omium.org>
> ---
> We have crash telemetry watching for "Unhandled context fault", so we
> want to preserve this error msg.
> 
>  drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> index 723273440c21..8321962b3714 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> @@ -417,7 +417,7 @@ void arm_smmu_read_context_fault_info(struct arm_smmu_device *smmu, int idx,
>  void arm_smmu_print_context_fault_info(struct arm_smmu_device *smmu, int idx,
>  				       const struct arm_smmu_context_fault_info *cfi)
>  {
> -	dev_dbg(smmu->dev,
> +	dev_err(smmu->dev,
>  		"Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra=0x%x, cb=%d\n",
>  		cfi->fsr, cfi->iova, cfi->fsynr, cfi->cbfrsynra, idx);
>  
> -- 
> 2.46.0
>
Yup, this should be changed back to dev_err.
Reviewed-by: Pranjal Shrivastava <praan@...gle.com>