linux-kernel - Re: [PATCH v2] cpufreq/amd-pstate: Add the missing cpufreq_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <484da8d3-c03a-4315-8861-93888adece47@amd.com>
Date: Fri, 9 Aug 2024 10:57:10 +0530
From: Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: ray.huang@....com, gautham.shenoy@....com, mario.limonciello@....com,
 perry.yuan@....com, rafael@...nel.org, li.meng@....com,
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()



On 8/9/2024 10:44 AM, Viresh Kumar wrote:
> On 08-08-24, 12:36, Dhananjay Ugwekar wrote:
>> Fix the reference counting of cpufreq_policy object in amd_pstate_update()
>> function by adding the missing cpufreq_cpu_put().
>>
>> Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current frequency value")
>> Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>
>> Reviewed-by: Perry Yuan <perry.yuan@....com>
>> ---
>>  drivers/cpufreq/amd-pstate.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
>> index 804fab4ebb26..36edae40db1a 100644
>> --- a/drivers/cpufreq/amd-pstate.c
>> +++ b/drivers/cpufreq/amd-pstate.c
>> @@ -560,6 +560,8 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
>>  
>>  	amd_pstate_update_perf(cpudata, min_perf, des_perf,
>>  			       max_perf, fast_switch);
>> +
>> +	cpufreq_cpu_put(policy);
> 
> There is an early return path in this routine, which still doesn't
> perform this action.

Thanks for catching this, will fix in next version

Regards,
Dhananjay

>