linux-kernel - Re: [PATCH 1/1] Net: bcm.c: Remove Subtree Instead of Entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240809202833.16882-1-kuniyu@amazon.com>
Date: Fri, 9 Aug 2024 13:28:33 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuniyu@...zon.com>
CC: <davem@...emloft.net>, <david.hunter.linux@...il.com>,
	<edumazet@...gle.com>, <javier.carrasco.cruz@...il.com>, <kuba@...nel.org>,
	<linux-can@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<mkl@...gutronix.de>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<skhan@...uxfoundation.org>, <socketcan@...tkopp.net>
Subject: Re: [PATCH 1/1] Net: bcm.c: Remove Subtree Instead of Entry

From: Kuniyuki Iwashima <kuniyu@...zon.com>
Date: Fri, 9 Aug 2024 13:22:49 -0700
> From: Oliver Hartkopp <socketcan@...tkopp.net>
> Date: Fri, 9 Aug 2024 11:57:41 +0200
> > Hello David,
> > 
> > many thanks for the patch and the description.
> > 
> > Btw. the data structures of the elements inside that bcm proc dir should 
> > have been removed at that point, so that the can-bcm dir should be empty.
> > 
> > I'm not sure what happens to the open sockets that are (later) removed 
> > in bcm_release() when we use remove_proc_subtree() as suggested. 
> > Removing this warning probably does not heal the root cause of the issue.
> 
> I posted a patch to fix bcm's proc entry leak few weeks ago, and this might
> be related.
> https://lore.kernel.org/netdev/20240722192842.37421-1-kuniyu@amazon.com/

I just noticed the syzbot report that David pointed out has the same
splat, so this is the same issue that my patch fixes.

https://syzkaller.appspot.com/bug?extid=df49d48077305d17519a