linux-kernel - Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240809232928.GB25056@yjiang5-mobl.amr.corp.intel.com>
Date: Fri, 9 Aug 2024 16:29:28 -0700
From: Yunhong Jiang <yunhong.jiang@...ux.intel.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
	dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
	decui@...rosoft.com, rafael@...nel.org, lenb@...nel.org,
	kirill.shutemov@...ux.intel.com, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-hyperv@...r.kernel.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox

On Thu, Aug 08, 2024 at 09:41:16AM +0200, Krzysztof Kozlowski wrote:
> On 07/08/2024 18:56, Yunhong Jiang wrote:
> > On Wed, Aug 07, 2024 at 07:57:43AM +0200, Krzysztof Kozlowski wrote:
> >> On 07/08/2024 00:12, Yunhong Jiang wrote:
> >>> Add the binding to use the ACPI wakeup mailbox mechanism to bringup APs.
> >>
> >> We do not have bindings for ACPI. I think in the past it was mentioned
> >> pretty clear - we do not care what ACPI has in the wild.
> > 
> > Thank you for review.
> > Can you please give a bit more information on "do not have bindings for ACPI"?
> > We don't put the ACPI table into the device tree, but reuse some existing ACPI
> > mailbox mechanism. Is this acceptable for you?
> 
> I understood that rationale behind this patch is "ACPI" thus that reply.
> This one sentence in commit msg is not helping. Entire binding
> description speaks about ACPI, so yeah - I don't care what ACPI does.
> Provide proper explanation/description of firmware or hardware, then
> sure. But the patch saying ACPI is doing something, so bindings will be
> doing the same is for me NAK. Whatever ACPI is doing is never a reason
> alone to do the same in Devicetree.

Thank you for the explanation. I will make the description as ACPI independent.

> 
> Best regards,
> Krzysztof
> 
>