linux-kernel - Re: [PATCH v1 7/7] i2c: npcm: fix checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b54d11728eebb5307c1bf8ce290764bb001c725e.camel@codeconstruct.com.au>
Date: Fri, 09 Aug 2024 16:20:11 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: warp5tw@...il.com, tali.perry@...oton.com, Avi.Fishman@...oton.com, 
 tomer.maimon@...oton.com, avifishman70@...il.com, tmaimon77@...il.com, 
 tali.perry1@...il.com, venture@...gle.com, yuenn@...gle.com, 
 benjaminfair@...gle.com, andi.shyti@...nel.org,
 wsa+renesas@...g-engineering.com,  rand.sec96@...il.com, kwliu@...oton.com,
 jjliu0@...oton.com, kfting@...oton.com
Cc: openbmc@...ts.ozlabs.org, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 7/7] i2c: npcm: fix checkpatch

Hello,

On Wed, 2024-08-07 at 18:02 +0800, warp5tw@...il.com wrote:
> From: Tyrone Ting <kfting@...oton.com>
> 
> Fix checkpatch warning.
> 
> Fixes: 48acf8292280 ("i2c: Remove redundant comparison in npcm_i2c_reg_slave")
> Signed-off-by: Tyrone Ting <kfting@...oton.com>
> ---
>  drivers/i2c/busses/i2c-npcm7xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
> index 1af6a927b9c1..dbe652d628ee 100644
> --- a/drivers/i2c/busses/i2c-npcm7xx.c
> +++ b/drivers/i2c/busses/i2c-npcm7xx.c
> @@ -1783,7 +1783,7 @@ static int npcm_i2c_int_master_handler(struct npcm_i2c *bus)
>  		/* reenable slave if it was enabled */
>  		if (bus->slave)
>  			iowrite8((bus->slave->addr & 0x7F) | NPCM_I2CADDR_SAEN,
> -				bus->reg + NPCM_I2CADDR1);
> +				 bus->reg + NPCM_I2CADDR1);
>  #endif
>  		return 0;
>  	}

Fixing checkpatch warnings means you need to modify the commit that
checkpatch identified as having problems, not just add a fix-up patch
on top.

It looks like this change should be squashed into the patch before it.

Andrew