linux-kernel - Re: [PATCH v3 2/2] i2c: Add Congatec CGEB I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <htilttfnytacgk6rqsnmeamyvoaglfwhwbgkc6cxkxt5h4yk3n@l65rbpa6mkfy>
Date: Fri, 9 Aug 2024 01:55:17 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Mary Strodl <mstrodl@....rit.edu>
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, 
	urezki@...il.com, hch@...radead.org, linux-mm@...ck.org, lee@...nel.org, 
	linux-i2c@...r.kernel.org, s.hauer@...gutronix.de, christian.gmeiner@...il.com
Subject: Re: [PATCH v3 2/2] i2c: Add Congatec CGEB I2C driver

Hi Mary,

just skimmed through fast...

> +		dev_dbg(&adapter->dev,
> +				"%s: rd: %p/%ld wr: %p/%ld flags: 0x%08lx %s\n",
> +				__func__, rdbuf, rdlen, raw_wrbuf, wrlen + 1,
> +				flags,
> +				msgs[i].flags & I2C_M_RD ? "READ" : "WRITE");

please mind the alignment: align everuthyng under the "(".

...

> +	ret = i2c_add_adapter(&priv->adapter);
> +	if (ret < 0) {
> +		dev_err(&pdev->dev, "registration failed\n");
> +		return ret;

please use dev_err_probe();

Andi