linux-kernel - Re: [PATCH] iio: adc: pac1921: add missing error return in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66b5c5df76766_133d37031@njaxe.notmuch>
Date: Fri, 09 Aug 2024 09:31:43 +0200
From: Matteo Martelli <matteomartelli3@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, 
 Dan Carpenter <dan.carpenter@...aro.org>
Cc: jic23@...nel.org, 
 kernel-janitors@...r.kernel.org, 
 lars@...afoo.de, 
 linux-iio@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 matteomartelli3@...il.com
Subject: Re: [PATCH] iio: adc: pac1921: add missing error return in probe()

Christophe JAILLET wrote:
> Le 08/08/2024 à 21:28, Dan Carpenter a écrit :
> > This error path was intended to return, and not just print an error.  The
> > current code will lead to an error pointer dereference.
> > 
> > Fixes: 371f778b83cd ("iio: adc: add support for pac1921")
> > Signed-off-by: Dan Carpenter <dan.carpenter-QSEj5FYQhm4dnm+yROfE0A@...lic.gmane.org>
> > ---
> >   drivers/iio/adc/pac1921.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/pac1921.c b/drivers/iio/adc/pac1921.c
> > index d04c6685d780..8200a47bdf21 100644
> > --- a/drivers/iio/adc/pac1921.c
> > +++ b/drivers/iio/adc/pac1921.c
> > @@ -1168,8 +1168,8 @@ static int pac1921_probe(struct i2c_client *client)
> >   
> >   	priv->regmap = devm_regmap_init_i2c(client, &pac1921_regmap_config);
> >   	if (IS_ERR(priv->regmap))
> > -		dev_err_probe(dev, (int)PTR_ERR(priv->regmap),
> > -			      "Cannot initialize register map\n");
> > +		return dev_err_probe(dev, (int)PTR_ERR(priv->regmap),
> 
> The (int) is unusual.
>
The (int) explicit cast is to address Wconversion warnings since dev_err_probe
takes an int as argument.
> 
> CJ
> 
> > +				     "Cannot initialize register map\n");
> >   
> >   	devm_mutex_init(dev, &priv->lock);
> >   
> 

Thanks,
Matteo Martelli