linux-kernel - Re: [PATCH] lib/rhashtable: cleanup fallback check in bucket_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZrXLy6-EpFJdro8b@tiehlicka>
Date: Fri, 9 Aug 2024 09:56:59 +0200
From: Michal Hocko <mhocko@...e.com>
To: Davidlohr Bueso <dave@...olabs.net>
Cc: akpm@...ux-foundation.org, 21cnbao@...il.com,
	herbert@...dor.apana.org.au, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/rhashtable: cleanup fallback check in
 bucket_table_alloc()

On Tue 06-08-24 08:39:27, Davidlohr Bueso wrote:
> Upon allocation failure, the current check with the nofail bits
> is unnecessary, and further stands in the way of discouraging
> direct use of __GFP_NOFAIL. Remove this and replace with the
> proper way of determining if doing a non-blocking allocation
> for the nested table case.
> 
> Suggested-by: Michal Hocko <mhocko@...e.com>
> Signed-off-by: Davidlohr Bueso <dave@...olabs.net>

Thanks. This is not really something I feel qualified to ack but the
change looks good to me.

> ---
>  lib/rhashtable.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/rhashtable.c b/lib/rhashtable.c
> index dbbed19f8fff..6c902639728b 100644
> --- a/lib/rhashtable.c
> +++ b/lib/rhashtable.c
> @@ -189,7 +189,7 @@ static struct bucket_table *bucket_table_alloc(struct rhashtable *ht,
>  
>  	size = nbuckets;
>  
> -	if (tbl == NULL && (gfp & ~__GFP_NOFAIL) != GFP_KERNEL) {
> +	if (tbl == NULL && !gfpflags_allow_blocking(gfp)) {
>  		tbl = nested_bucket_table_alloc(ht, nbuckets, gfp);
>  		nbuckets = 0;
>  	}
> -- 
> 2.45.2

-- 
Michal Hocko
SUSE Labs