linux-kernel - Re: [PATCH] selftests: resctrl: ignore builds for unsupported architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <080c4692-c53c-417f-9975-0b4ced0b044c@collabora.com>
Date: Fri, 9 Aug 2024 13:05:38 +0500
From: Muhammad Usama Anjum <Usama.Anjum@...labora.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Usama.Anjum@...labora.com, Fenghua Yu <fenghua.yu@...el.com>,
 Reinette Chatre <reinette.chatre@...el.com>, Shuah Khan <shuah@...nel.org>,
 Shaopeng Tan <tan.shaopeng@...fujitsu.com>, kernel@...labora.com,
 Shuah Khan <skhan@...uxfoundation.org>, LKML <linux-kernel@...r.kernel.org>,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: resctrl: ignore builds for unsupported
 architectures

On 8/9/24 12:23 PM, Ilpo Järvinen wrote:
> On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote:
> 
>> This test doesn't have support for other architectures. Altough resctrl
>> is supported on x86 and ARM, but arch_supports_noncont_cat() shows that
>> only x86 for AMD and Intel are supported by the test.
> 
> One does not follow from the other. arch_supports_noncont_cat() is only 
> small part of the tests so saying "This test" based on a small subset of 
> all tests is bogus. Also, I don't see any reason why ARCH_ARM could not be 
> added and arch_supports_noncont_cat() adapted accordingly.
I'm not familiar with resctrl and the architectural part of it. Feel
free to fix it and ignore this patch.

If more things are missing than just adjusting
arch_supports_noncont_cat(), the test should be turned off until proper
support is added to the test.

> 
>> We get build
>> errors when built for ARM and ARM64.
> 
> As this seems the real reason, please quote any errors when you use them 
> as justification so it can be reviewed if the reasoning is sound or not.

  CC       resctrl_tests
In file included from resctrl.h:24,
                 from cat_test.c:11:
In function 'arch_supports_noncont_cat',
    inlined from 'noncont_cat_run_test' at cat_test.c:323:6:
../kselftest.h:74:9: error: impossible constraint in 'asm'
   74 |         __asm__ __volatile__ ("cpuid\n\t"
       \
      |         ^~~~~~~
cat_test.c:301:17: note: in expansion of macro '__cpuid_count'
  301 |                 __cpuid_count(0x10, 1, eax, ebx, ecx, edx);
      |                 ^~~~~~~~~~~~~
../kselftest.h:74:9: error: impossible constraint in 'asm'
   74 |         __asm__ __volatile__ ("cpuid\n\t"
       \
      |         ^~~~~~~
cat_test.c:303:17: note: in expansion of macro '__cpuid_count'
  303 |                 __cpuid_count(0x10, 2, eax, ebx, ecx, edx);
      |                 ^~~~~~~~~~~~~


-- 
BR,
Muhammad Usama Anjum