linux-kernel - Re: [PATCH] mwifiex: duplicate static structs used in driver instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrXR-VCQWnO8nMGe@pengutronix.de>
Date: Fri, 9 Aug 2024 10:23:21 +0200
From: Sascha Hauer <s.hauer@...gutronix.de>
To: Kalle Valo <kvalo@...nel.org>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	Yogesh Ashok Powar <yogeshp@...vell.com>,
	Bing Zhao <bzhao@...vell.com>,
	"John W. Linville" <linville@...driver.com>,
	Amitkumar Karwar <akarwar@...vell.com>,
	Avinash Patil <patila@...vell.com>,
	Kiran Divekar <dkiran@...vell.com>, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel@...gutronix.de,
	stable@...r.kernel.org
Subject: Re: [PATCH] mwifiex: duplicate static structs used in driver
 instances

On Fri, Aug 09, 2024 at 11:14:36AM +0300, Kalle Valo wrote:
> Sascha Hauer <s.hauer@...gutronix.de> writes:
> 
> > mwifiex_band_2ghz and mwifiex_band_5ghz are statically allocated, but
> > used and modified in driver instances. Duplicate them before using
> > them in driver instances so that different driver instances do not
> > influence each other.
> >
> > This was observed on a board which has one PCIe and one SDIO mwifiex
> > adapter. It blew up in mwifiex_setup_ht_caps(). This was called with
> > the statically allocated struct which is modified in this function.
> >
> > Cc: stable@...r.kernel.org
> > Fixes: d6bffe8bb520 ("mwifiex: support for creation of AP interface")
> > Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> 
> Should this go to wireless tree for v6.11?

Yes, that would be great.

> 
> "wifi:" missing in subject but I can add that, no need to resend because
> of this.

Ok, thanks. I'll keep that in mind for the next patches.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |