linux-kernel - RE: [PATCH v4 5/7] iommu/vt-d: Factor out helpers from domain_context_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276265C6C9B6B1AB7EE14788CBA2@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Fri, 9 Aug 2024 08:28:07 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>, "Will
 Deacon" <will@...nel.org>, Robin Murphy <robin.murphy@....com>, "Jason
 Gunthorpe" <jgg@...pe.ca>
CC: "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Jason
 Gunthorpe" <jgg@...dia.com>
Subject: RE: [PATCH v4 5/7] iommu/vt-d: Factor out helpers from
 domain_context_mapping_one()

> From: Lu Baolu <baolu.lu@...ux.intel.com>
> Sent: Friday, August 9, 2024 1:54 PM
> 
> Extract common code from domain_context_mapping_one() into new
> helpers,
> making it reusable by other functions such as the upcoming identity domain
> implementation. No intentional functional changes.
> 
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>

with a nit on naming:

> +static void copied_context_tear_down(struct intel_iommu *iommu,
> +				     struct context_entry *context,
> +				     u8 bus, u8 devfn)

tear_down_copied_conext


> +static void context_present_cache_flush(struct intel_iommu *iommu, u16
> did,
> +					u8 bus, u8 devfn)

flush_present_context_cache