linux-kernel - Re: [PATCH 1/3] ALSA: pcm: add support for 128kHz sample rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1jcymixfou.fsf@starbuckisacylon.baylibre.com>
Date: Fri, 09 Aug 2024 10:29:05 +0200
From: Jerome Brunet <jbrunet@...libre.com>
To: Takashi Iwai <tiwai@...e.de>
Cc: Amadeusz Sławiński
 <amadeuszx.slawinski@...ux.intel.com>, 	Mark Brown
 <broonie@...nel.org>,  Liam Girdwood <lgirdwood@...il.com>, 	Takashi Iwai
 <tiwai@...e.com>,  Jaroslav Kysela <perex@...ex.cz>,
 	alsa-devel@...a-project.org,  linux-sound@...r.kernel.org,
 	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ALSA: pcm: add support for 128kHz sample rate


>> 
>> Apart from the problem reported in sound/usb/caiaq/audio.c, is there
>> another clean up expected ?
>
> The change for caiaq/audio.c is rather a "fix" :)
> As a cleanup, I meant, whether this extension can be applied to the
> other existing drivers that already use 128kHz with RATE_KNOT and an
> extra list.

Grepping in sound/ for 128000, I've found only 3 files which could
benefit from solely adding 128kHz to the defined rates:

* sound/pci/cmipci.c
* sound/pci/rme9652/hdsp.c
* sound/pci/rme9652/hdspm.c

The rest are unsing other rates which require the use of RATE_KNOT.
The most regular rates being 12kHz and 24kHz. Adding those as well could
help in:

* sound/soc/codecs/adau1977.c
* sound/soc/fsl/fsl_asrc.c
* sound/soc/fsl/fsl_easrc.c
* sound/soc/intel/avs/pcm.c

I admit that's a fairly low number of drivers, maybe it is not worth it
at this stage.

Takashi, Mark, what is your preference ? Should I:
 * tweak the spdif codec to use RATE_KNOT ?
 * add just 128kHz, fixing the 3 file above ?
 * add 12 and 24kHz as well ?

I don't really mind one way or the other.

>
>
> thanks,
>
> Takashi

-- 
Jerome