linux-kernel - [PATCH 2/2] virtio-pci: Do not break the error message for VIRTIO_F_VERSION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240809083549.14772-2-manivannan.sadhasivam@linaro.org>
Date: Fri,  9 Aug 2024 14:05:48 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: mst@...hat.com,
	jasowang@...hat.com
Cc: xuanzhuo@...ux.alibaba.com,
	eperezma@...hat.com,
	virtualization@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: [PATCH 2/2] virtio-pci: Do not break the error message for VIRTIO_F_VERSION_1

Breaking the error message will make it harder to grep for it in the
driver. So let's put the error message in a single line.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
---
 drivers/virtio/virtio_pci_modern.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c
index e34ed4870af4..1bb55a3167a5 100644
--- a/drivers/virtio/virtio_pci_modern.c
+++ b/drivers/virtio/virtio_pci_modern.c
@@ -274,8 +274,8 @@ static int vp_finalize_features(struct virtio_device *vdev)
 	vp_transport_features(vdev, features);
 
 	if (!__virtio_test_bit(vdev, VIRTIO_F_VERSION_1)) {
-		dev_err(&vdev->dev, "device uses modern interface "
-			"but does not have VIRTIO_F_VERSION_1\n");
+		dev_err(&vdev->dev,
+			"device uses modern interface but does not have VIRTIO_F_VERSION_1\n");
 		return -EINVAL;
 	}
 
-- 
2.25.1