linux-kernel - Re: [PATCH] media: rockchip: rga: fix offset lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39c7bd1a-abe9-44e5-b6dd-cb7b3c3e2e6e@xs4all.nl>
Date: Fri, 9 Aug 2024 10:45:17 +0200
From: Hans Verkuil <hverkuil@...all.nl>
To: John Keeping <jkeeping@...usicbrands.com>, linux-media@...r.kernel.org
Cc: Jacob Chen <jacob-chen@...wrt.com>,
 Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Heiko Stuebner
 <heiko@...ech.de>, linux-rockchip@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Michael Tretter <m.tretter@...gutronix.de>
Subject: Re: [PATCH] media: rockchip: rga: fix offset lookup

+Michael Tretter

Michael, can you confirm this?

Regards,

	Hans

On 06/08/2024 11:48, John Keeping wrote:
> The rot_mir_point_matrix is arranged with the rotation values in rows
> and mirror settings in the columns.  Fix the order of indexing to match
> this so that the correct values are used.
> 
> Signed-off-by: John Keeping <jkeeping@...usicbrands.com>
> ---
>  drivers/media/platform/rockchip/rga/rga-hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/rockchip/rga/rga-hw.c b/drivers/media/platform/rockchip/rga/rga-hw.c
> index 11c3d72347572..b7d51ddb10fa4 100644
> --- a/drivers/media/platform/rockchip/rga/rga-hw.c
> +++ b/drivers/media/platform/rockchip/rga/rga-hw.c
> @@ -97,7 +97,7 @@ static struct rga_addr_offset *rga_lookup_draw_pos(struct
>  	if (!offsets)
>  		return NULL;
>  
> -	switch (rot_mir_point_matrix[rotate_mode][mirr_mode]) {
> +	switch (rot_mir_point_matrix[mirr_mode][rotate_mode]) {
>  	case LT:
>  		return &offsets->left_top;
>  	case LB: